Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic cyclonedx output #258

Merged
merged 2 commits into from
Sep 14, 2024
Merged

Deterministic cyclonedx output #258

merged 2 commits into from
Sep 14, 2024

Conversation

LogFlames
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This is a suggested solution to #135.

By sorting the array of components, dependencies and sub-dependencies of the created cyclonedx BOM output is deterministic.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 12, 2024 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@LogFlames
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@LogFlames LogFlames force-pushed the feat/deterministicCyclonedxJsonOutput branch from 5ae0d26 to d12adf1 Compare June 12, 2024 15:26
@LogFlames
Copy link
Contributor Author

LogFlames commented Jun 17, 2024 •
edited
Loading

Some workflows must be approved by a maintainer, @eyalbe4 can you help?

@eyalbe4 eyalbe4 self-requested a review June 17, 2024 16:58
@eyalbe4 eyalbe4 closed this Jul 15, 2024
@eyalbe4 eyalbe4 reopened this Jul 15, 2024
@eyalbe4 eyalbe4 added the bug Something isn't working label Jul 15, 2024
@LogFlames
Copy link
Contributor Author

Hi, what needs to be done to get this merged?

@LogFlames LogFlames force-pushed the feat/deterministicCyclonedxJsonOutput branch from 7371473 to 3345628 Compare August 28, 2024 14:10
@LogFlames LogFlames force-pushed the feat/deterministicCyclonedxJsonOutput branch from bd7344b to bd5e9b3 Compare September 8, 2024 20:54
@LogFlames LogFlames force-pushed the feat/deterministicCyclonedxJsonOutput branch from bd5e9b3 to 389f766 Compare September 8, 2024 21:00
@LogFlames
Copy link
Contributor Author

LogFlames commented Sep 8, 2024 •
edited
Loading

Hi @eyalbe4 ,

I'm very sorry for the ugly/long history. An accidental failed rebase on my part. It is now rebased on top of the latest in dev. Is there something more needed to get this merged?

@eyalbe4 eyalbe4 closed this Sep 9, 2024
@eyalbe4 eyalbe4 reopened this Sep 9, 2024
@eyalbe4 eyalbe4 merged commit 2241346 into jfrog:dev Sep 14, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LogFlames @eyalbe4