Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-info-extractor-gradle: use container api for configuration cach… #705

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martin-walsh
Copy link

@martin-walsh martin-walsh commented Feb 8, 2023

Opening this PR as a conversation starter around support for new --configuration-cache flag in Gradle.

Essentially, if a project uses any plugins which do not defer creation of Tasks, a user cannot make use of configuration cache.

The main changes required are to use the lazy init apis i.e. register vs create & named vs findByName.

The code looks like it requires more changes than I have made here so far, but before I do so, it's best to discuss.

See:

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@martin-walsh
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@martin-walsh
Copy link
Author

recheck

@martin-walsh martin-walsh marked this pull request as ready for review February 8, 2023 04:18
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Feb 8, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Feb 8, 2023
@martin-walsh
Copy link
Author

@yahavi How can I start a discussion on this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants