Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create fixing pull request for violations #370

Merged
merged 4 commits into from
Jun 29, 2023
Merged

Fix create fixing pull request for violations #370

merged 4 commits into from
Jun 29, 2023

Conversation

omerzi
Copy link
Member

@omerzi omerzi commented Jun 28, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • While configuring Platform watches, the process of creating a fixing pull request was not functioning correctly because the violations were not being inserted into the vulnerable details map.
  • I have added a test to cover this specific situation.

@omerzi omerzi added bug Something isn't working safe to test Approve running integration tests on a pull request labels Jun 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 28, 2023
@github-actions
Copy link
Contributor

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

1 similar comment
@github-actions
Copy link
Contributor

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@omerzi omerzi requested a review from eyalbe4 June 28, 2023 09:11
eyalbe4
eyalbe4 requested changes Jun 28, 2023
View reviewed changes
commands/createfixpullrequests_test.go Outdated Show resolved Hide resolved
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Jun 28, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 28, 2023
@github-actions
Copy link
Contributor

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@omerzi omerzi added the safe to test Approve running integration tests on a pull request label Jun 29, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 29, 2023
@omerzi omerzi merged commit 16323ba into jfrog:dev Jun 29, 2023
10 of 11 checks passed
@github-actions
Copy link
Contributor

  • Frogbot also supports Contextual Analysis, Infrastructure as Code Scanning and Secrets Detection. These features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.

@omerzi omerzi deleted the create-violations-fix branch July 23, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omerzi @eyalbe4