Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combining UpdateDependency test for all package managers #462

Merged
merged 10 commits into from
Aug 30, 2023
Merged

Combining UpdateDependency test for all package managers #462

merged 10 commits into from
Aug 30, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Aug 30, 2023 •
edited
Loading

…python, nuget)

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Combining all separate updateDependency tests of all package managers into a single test

@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 30, 2023 09:56 — with GitHub Actions Inactive
EyalDelarea
EyalDelarea suggested changes Aug 30, 2023
View reviewed changes
packagehandlers/commonpackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/packagehandlers_test.go Outdated Show resolved Hide resolved
packagehandlers/packagehandlers_test.go Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 30, 2023 11:24 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman changed the title Combining all package managers UpdateDependency test Combining UpdateDependency test for all package managers Aug 30, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot August 30, 2023 12:13 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2023
@github-actions
Copy link
Contributor

@eranturgeman eranturgeman merged commit 67360aa into jfrog:dev Aug 30, 2023
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EyalDelarea EyalDelarea EyalDelarea requested changes

@sverdlov93 sverdlov93 Awaiting requested review from sverdlov93

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @EyalDelarea