Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle create fix pull request #478

Merged
merged 50 commits into from
Sep 28, 2023

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Sep 7, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

'create-fix-pull-request' for Gradle projects is now supported!
Frogbot currently supports fixing the following for Gradle projects:

  • fixing direct dependency written in a string format (i.e. "groupName:packageName:packageVersion...") for groovy and kotlin build files
  • fixing direct dependency written in a map format (i.e. "group: groupName, name: packageName, version: packageVersion ...") for groovy and kotlin build files
  • fixing dependencies for a multi-module project

Frogbot currently doesn't support the following for Gradle projects:

  • versions: latest (version = latest.release), range version ( [3.4, 4.7) ), dynamic version (4.+)
  • versions derived from variables
  • versions derived from other projects/ scripts/ files/ plugins

@eranturgeman eranturgeman temporarily deployed to frogbot September 26, 2023 11:40 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Sep 26, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 26, 2023
packagehandlers/gradlepackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/gradlepackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/gradlepackagehandler.go Outdated Show resolved Hide resolved
packagehandlers/gradlepackagehandler.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman temporarily deployed to frogbot September 27, 2023 07:47 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@eranturgeman eranturgeman temporarily deployed to frogbot September 27, 2023 13:51 — with GitHub Actions Inactive
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 27, 2023
@github-actions
Copy link
Contributor


@eranturgeman eranturgeman merged commit dbddec5 into jfrog:dev Sep 28, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants