Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded Frogbot to use node20 #770

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Upgraded Frogbot to use node20 #770

wants to merge 2 commits into from

Conversation

eyalk007
Copy link

@eyalk007 eyalk007 commented Oct 17, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.
  • Update documentation about new features / new supported technologies

This pull request upgrades Frogbot to use node-20 instead of node-16.

in GitHub actions, node-16 is considered deprecated(thus uses node20 automatically), and so we have fully up upgraded Frogbot to use node-20

image

@eyalk007 eyalk007 self-assigned this Oct 17, 2024
@eyalk007 eyalk007 changed the title upgraded frogbot to use node20 Upgraded frogbot to use node20 Oct 17, 2024
@eyalk007 eyalk007 added the improvement Automatically generated release notes label Oct 17, 2024
@eyalk007 eyalk007 added the safe to test Approve running integration tests on a pull request label Oct 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 17, 2024
@eyalk007 eyalk007 requested a review from eranturgeman October 17, 2024 09:26
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalk007 eyalk007 linked an issue Oct 17, 2024 that may be closed by this pull request
Update action to use node 20 #678
Open
@eyalk007 eyalk007 changed the title Upgraded frogbot to use node20 Upgraded Frogbot to use node20 Oct 17, 2024
@eyalk007
Copy link
Author

will be merged in Frogbot v3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

Assignees

@eyalk007 eyalk007

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update action to use node 20
1 participant
@eyalk007