Pass multiple values to JF_WORKING_DIR #785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
added
the
safe to test
github-actions
bot
removed
the
safe to test
hadarshjfrog
reviewed
Dec 3, 2024
| @@ -95,15 +95,14 @@ type Project struct { | |||
|
|
|||
| func (p *Project) setDefaultsIfNeeded() error { | |||
There was a problem hiding this comment.
Please add a test to the multiple working dirs.
Also - adjust the documentation (I guess it's a "," delimiter) - need to point that specifically.
hadarshjfrog
reviewed
Dec 3, 2024
| workingDir := getTrimmedEnv(WorkingDirectoryEnv) | ||
| if workingDir == "" { | ||
|
|
||
| workingDirs, _ := readArrayParamFromEnv(WorkingDirectoryEnv, WatchesDelimiter) |
There was a problem hiding this comment.
if we're using WatchesDelimiter for both - let's change its name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add option to parse multiple working dirs to
JF_WORKING_DIRenvironment variable separated by,