Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize to latest versions supported by Java 8 #841

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sghill-rewrite
Copy link

Hi!

This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further.

This PR was generated with an OpenRewrite recipe on Moderne.io.

Additionally I enabled maven enforcer by adding the required excludes and relying on the parent POM's enforcer config.


@github-actions
Copy link

github-actions bot commented Jul 15, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sghill
Copy link

sghill commented Jul 15, 2023

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@sghill-rewrite
Copy link
Author

sghill-rewrite commented Jul 15, 2023 via email

@sghill-rewrite
Copy link
Author

recheck

@sghill
Copy link

sghill commented Jul 19, 2023

@yahavi I saw you merged a recent PR, would you be able to look at this one or point me to someone who could?

It'd be great to modernize this important plugin so it didn't install so many implicit plugin dependencies

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Jul 20, 2023
@jonesbusy
Copy link

I think this PR could have been prevented #845

@yahavi
Copy link
Member

yahavi commented Jul 23, 2023

@sghill-rewrite
Thanks for this contribution!

It looks like some of the integration tests are failing with:

Error: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/http/client/methods/HttpUriRequest

@sghill
Copy link

sghill commented Jul 23, 2023

Thanks for taking a look @yahavi!

Looks like these integration tests require some extra setup. Any advice on running them locally so I can debug?

I was able to run some of the DeclarativeITest suite setup locally, but most tests were skipped due to missing environment variables. I suppose those need to point to running services?

I did notice the logs included that parameterized-trigger must be updated to run with the git plugin, but I don't see parameterized-trigger referenced in the project.

@jonesbusy jonesbusy mentioned this pull request Jul 25, 2023
3 tasks
@sghill
Copy link

sghill commented Jul 26, 2023

Related to #847

@rahulsom
Copy link

rahulsom commented Jul 27, 2023

Hey @sghill! I was trying to change as little as possible on my PR.
I thought I would rewrite the integration tests to use test containers instead of relying on running local services.

@sghill
Copy link

sghill commented Jul 27, 2023

Sounds great @rahulsom! Happy to rebase here when that's ready or break this down into smaller PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Approve running integration tests on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants