Support pipe and new line in the 'No proxy host' #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Nathan770
force-pushed
the
fix-no-proxy
branch
from
c49255f
to
87aba78
Compare
yahavi
added
improvement
github-actions
bot
removed
the
safe to test
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
reviewed
Sep 19, 2024
yahavi
requested changes
Sep 19, 2024
src/test/java/io/jenkins/plugins/jfrog/NoProxyExtractorTest.java
Outdated
Show resolved
Hide resolved
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
requested changes
Sep 19, 2024
src/test/java/io/jenkins/plugins/jfrog/NoProxyExtractorTest.java
Outdated
Show resolved
Hide resolved
src/test/java/io/jenkins/plugins/jfrog/NoProxyExtractorTest.java
Outdated
Show resolved
Hide resolved
yahavi
added
the
safe to test
github-actions
bot
removed
the
safe to test
yahavi
reviewed
Sep 20, 2024
src/test/java/io/jenkins/plugins/jfrog/CreateNoProxyValueTest.java
Outdated
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #105
Implemented a new function to properly extract and format the "No Proxy Host" list from Jenkins configurations.
Enhanced support for multiple delimiters, including pipe (|), newline, and semicolon (;), ensuring that the "No Proxy Host" values are parsed and handled correctly.