-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secret Token Validation feature #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
attiasas
requested changes
Aug 18, 2024
…o token-validation
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 12, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 12, 2024
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 12, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 12, 2024
barv-jfrog
had a problem deploying
to
frogbot
September 16, 2024 07:37 — with
GitHub Actions
Failure
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 16, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 16, 2024
barv-jfrog
had a problem deploying
to
frogbot
September 17, 2024 09:46 — with
GitHub Actions
Failure
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
barv-jfrog
had a problem deploying
to
frogbot
September 17, 2024 09:59 — with
GitHub Actions
Failure
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
barv-jfrog
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.Depends on - jfrog/documentation#145
Depends on - jfrog/jfrog-client-go#991
Description - adding a flag --validate-secrets to jf audit and jf docker scan so secrets found will trigger token validation on XRAY. Token validation takes secrets that are api tokens for example amazon secret key and checks if this key is still valid on amazon side. The capability is identical to audit and docker scan.
What I do is I pass an env var to analyzermanager because analyzers contain an env variable which according to its value (true/false) turns on the Gadget which is responsible for token validation.
As you see, there are multiple options to pass this env var, first through flag --validate-secrets, second through env var defined in user setup, third XRAY API which exists only from 3.101.0. otherwise it returns False.
OLD PR - #128