Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate xray url #160

Merged
merged 13 commits into from
Oct 31, 2024
Merged

Validate xray url #160

merged 13 commits into from
Oct 31, 2024

Conversation

hadarshjfrog
Copy link
Contributor

@hadarshjfrog hadarshjfrog commented Aug 30, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

When configuring xray-url only, without the url - the audit command didn't recognize them, and couldn't set JAS scanners:

I keep getting this warning “To include 'Advanced Security' scan as part of the audit output, please run the 'jf c add' command before running this command.“ when running the jf audit.

The command I use to reproduce the issue:
jf c add "test" --xray-url="PLATFORM_URL" --interactive=false --access-token="access-token*****"

I was able to solve it using the following cmd:
jf c add "test" --url="PLATFORM_URL" --interactive=false --access-token="access-token******"

@hadarshjfrog hadarshjfrog added bug Something isn't working safe to test Approve running integration tests on a pull request labels Aug 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Aug 30, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 30, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 3, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Sep 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 8, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Sep 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 16, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Sep 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 17, 2024
@orz25
Copy link
Contributor

orz25 commented Sep 17, 2024

@hadarshjfrog I think it's worth adding a test to audit_test.go - configure a server with Xray URL only and validate we get JAS results

@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 29, 2024
@hadarshjfrog hadarshjfrog added the safe to test Approve running integration tests on a pull request label Oct 31, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 31, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


@hadarshjfrog hadarshjfrog merged commit 3e0a6a7 into jfrog:dev Oct 31, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants