Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore test secrets in scans #17

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Ignore test secrets in scans #17

merged 1 commit into from
Jan 29, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Jan 29, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.

Ignore results that shows at JFrog secret scan.
Reason: Test cases

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jan 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 29, 2024
@attiasas attiasas requested a review from eranturgeman January 29, 2024 11:27
@attiasas attiasas merged commit 0fc5abe into jfrog:dev Jan 29, 2024
7 of 8 checks passed
@attiasas attiasas deleted the add_ignore_test_sec branch January 29, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranturgeman eranturgeman Awaiting requested review from eranturgeman

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@attiasas