-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Auto-installation in Audit SCA scan if requested by user (Yarn, NPM, Go) #191
Merged
eranturgeman
merged 22 commits into
jfrog:dev
from
eranturgeman:skip-scan-if-auto-install-skipped-in-uninstalled-project
Oct 10, 2024
Merged
Skip Auto-installation in Audit SCA scan if requested by user (Yarn, NPM, Go) #191
eranturgeman
merged 22 commits into
jfrog:dev
from
eranturgeman:skip-scan-if-auto-install-skipped-in-uninstalled-project
Oct 10, 2024
+237
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uction + added test case for the new scenario
…est for this scenario
…o skip-scan-if-auto-install-skipped-in-uninstalled-project
eranturgeman
temporarily deployed
to
frogbot
September 25, 2024 14:23 — with
GitHub Actions
Inactive
eranturgeman
added
new feature
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Sep 25, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
4 tasks
eranturgeman
had a problem deploying
to
frogbot
September 25, 2024 15:14 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 25, 2024
attiasas
requested changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also add it as a flag option to audit
- --skip-install
. we will need this in the future for the integrated tools
@attiasas Af for the comment you left - I will open a Jira ticket to add the flag, as this is not part of the current feature |
eranturgeman
had a problem deploying
to
frogbot
September 30, 2024 11:53 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Sep 30, 2024
…o skip-scan-if-auto-install-skipped-in-uninstalled-project
eranturgeman
had a problem deploying
to
frogbot
September 30, 2024 11:55 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 1, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 1, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 6, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 6, 2024
eranturgeman
changed the title
Skip Auto-installation in Audit Sca scan if requested by user
Skip Auto-installation in Audit SCA scan if requested by user
Oct 10, 2024
eranturgeman
changed the title
Skip Auto-installation in Audit SCA scan if requested by user
Skip Auto-installation in Audit SCA scan if requested by user (Yarn, NPM, Go)
Oct 10, 2024
…o skip-scan-if-auto-install-skipped-in-uninstalled-project
eranturgeman
had a problem deploying
to
frogbot
October 10, 2024 10:35 — with
GitHub Actions
Failure
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
commented
Oct 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
attiasas
approved these changes
Oct 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
eranturgeman
added
ignore for release
Automatically generated release notes
and removed
new feature
Automatically generated release notes
labels
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.This PR introduces a new ability that allows skip auto installation in a project/module that is not installed and not specifically forced to be installed (using provision of an install command)
This ability is currently available for Yarn and NPM only (and for Golang since no installation required in it).
The ability is usable through Frogbot using JF_SKIP_AUTO_INSTALL env var (jfrog/frogbot#758)
In addition, a new flag was added to enable using this ability through the CLI: --skip-auto-install
Linked PR: jfrog/build-info-go#277
Failure in Nuget/.NET tests is known