-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable allow-partial-results for Audit SCA scan and dep tree construction #200
Merged
eranturgeman
merged 13 commits into
jfrog:dev
from
eranturgeman:enable-partial-results-scan-repo-sca
Oct 13, 2024
Merged
Enable allow-partial-results for Audit SCA scan and dep tree construction #200
eranturgeman
merged 13 commits into
jfrog:dev
from
eranturgeman:enable-partial-results-scan-repo-sca
Oct 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter SCA scan execution
…rting the error to it in case we have an error
…+ the handler function
…rrorIfPartialResultsDisabled
eranturgeman
added
new feature
Automatically generated release notes
safe to test
Approve running integration tests on a pull request
labels
Oct 6, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 6, 2024
…lti working dirs) repo
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 8, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 8, 2024
eranturgeman
changed the title
Enable partial results for Audit SCA scan and dep tree construction
Enable allow-partial-results for Audit SCA scan and dep tree construction
Oct 8, 2024
4 tasks
attiasas
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, take a look at my comments
tests/testdata/projects/package-managers/npm/npm-un-installable/package.json
Show resolved
Hide resolved
…o enable-partial-results-scan-repo-sca
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
attiasas
approved these changes
Oct 10, 2024
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
…o enable-partial-results-scan-repo-sca # Conflicts: # cli/docs/flags.go # cli/scancommands.go # commands/audit/scarunner.go # utils/auditbasicparams.go
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 10, 2024
…o enable-partial-results-scan-repo-sca
eranturgeman
added
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
github-actions
bot
removed
the
safe to test
Approve running integration tests on a pull request
label
Oct 13, 2024
eranturgeman
added
ignore for release
Automatically generated release notes
and removed
new feature
Automatically generated release notes
labels
Oct 13, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
branch.go vet ./...
.go fmt ./...
.This PR introduces a new ability that allows partial scan results without failing the entire scan over a single failing part in the scans (for example when we have multiple working directories and the scan on one of them have failed - we will not fail the entire scan, but rather log the error of the failing scan and continue).
This ability should be applied for SCA scans as well as for JAS scans but currently, until the security cli refactor (#96) will be merged it is applied only for SCA scans
Applying this ability to JAS scans will be on a different PR
In addition, a new flag was added to enable using this ability from the cli: --allow-partial-results
This PR contains also 2 bug fixes:
Note: Some of the NuGet Audit tests fail. This issue is known and will be fixed soon