Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape Job-Id for url #272

Merged
merged 3 commits into from
Dec 26, 2024
Merged

Escape Job-Id for url #272

merged 3 commits into from
Dec 26, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Dec 26, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Github Job Id can be a not escaped value resulting in errors on SARIF upload
image

Also changing the padding of the analytics pixel to space and not new line to avoid display issues
image
image

@attiasas attiasas added bug Something isn't working safe to test Approve running integration tests on a pull request labels Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils/results/output 0.00% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/results/output/securityJobSummary.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/jfrog/jfrog-cli-security/utils/results/conversion/sarifparser/sarifparser_test.go
  • github.com/jfrog/jfrog-cli-security/utils/results/output/securityJobSummary_test.go

@attiasas attiasas merged commit c238f29 into jfrog:dev Dec 26, 2024
8 of 9 checks passed
@attiasas attiasas deleted the escape_query_params branch December 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants