Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testdata project path in Yarn tests #40

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Mar 14, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR fixs testdata project path in yarn tests. The local path for the tests projects was changed during the migration to security-cli but the path wasn't changed in the tests.
The tests currently pass in Prod since the machine that runs the tests contains lower yarn version (Yarn 1), that enables running 'install' on an empty directory, which causes the tests to pass without actually checking what the test is intended to check.
This is not allowed in higher yarn versions.

@eranturgeman eranturgeman added bug Something isn't working safe to test Approve running integration tests on a pull request labels Mar 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@eranturgeman eranturgeman requested a review from attiasas March 14, 2024 13:07
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2024
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 14, 2024
@eranturgeman eranturgeman merged commit 5bc1339 into jfrog:dev Mar 14, 2024
12 checks passed
@attiasas attiasas added ignore for release Automatically generated release notes and removed bug Something isn't working labels Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants