Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to support Pnpm in frogbot #41

Merged

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Mar 17, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This pull request implements modifications to the Pnpm audit flow in order to facilitate Frogbot's PNPM support. When auditing a Pnpm project and performing the 'install' operation, a node_modules directory is generated, which becomes redundant after the dependency calculation. Thus, we remove it if it didn't exist previously, ensuring no residual trace is left behind from the 'install' action.

@eranturgeman eranturgeman marked this pull request as draft March 17, 2024 14:54
@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Mar 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 17, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 17, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman requested a review from attiasas March 19, 2024 15:17
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman marked this pull request as ready for review March 19, 2024 15:17
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 19, 2024
@eranturgeman eranturgeman mentioned this pull request Mar 19, 2024
3 tasks
@eranturgeman eranturgeman requested a review from omerzi March 20, 2024 08:13
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 20, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 20, 2024
commands/audit/sca/pnpm/pnpm.go Outdated Show resolved Hide resolved
commands/audit/sca/pnpm/pnpm.go Outdated Show resolved Hide resolved
commands/audit/sca/pnpm/pnpm.go Outdated Show resolved Hide resolved
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
Copy link

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.


@eranturgeman eranturgeman merged commit cac7479 into jfrog:dev Mar 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants