Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in parallel #45

Closed
wants to merge 4 commits into from
Closed

Run tests in parallel #45

wants to merge 4 commits into from

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented Mar 21, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

TODO:

  1. Update actions and use cache
  2. Re structure test data to better places (also move npm folder... move artifactory configs to others...)
    image
  3. Try move integration tests to its own new dir integrationtests in tests

Running Tests in Parallel, Splitting Based on Types

  • This approach reduces run time from approximately 30 minutes to about 15 minutes.
  • Adding -race missing flag for tests
  • It enables running partial tests locally by types or executing all of them using simple flags.

Confirmation: All Tests Are Passing (Note: This will only pass after the merge)

image

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Mar 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Mar 21, 2024
tests/config.go Outdated Show resolved Hide resolved
tests/config.go Outdated Show resolved Hide resolved
Copy link
Contributor

@eranturgeman eranturgeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to organize dependencies in the files you worked in

@attiasas
Copy link
Contributor Author

attiasas commented Nov 4, 2024

Implemented at:

@attiasas attiasas closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants