Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding error logs report for audit scans #49

Merged
merged 47 commits into from
Apr 10, 2024
Merged

Adding error logs report for audit scans #49

merged 47 commits into from
Apr 10, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Apr 1, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Adding enhancements to the audit scan functionality.
In case of any errors during the execution of the 'audit' command, an error report is now dispatched to Coralogix, provided the Xsc service is enabled.

gailazar300 and others added 19 commits March 24, 2024 17:07
@gailazar300
Add Xsc General Event
12dbe00
@gailazar300
Add Xsc General Event
cbc4fcd
@gailazar300
Before review fixes.
1951727
@gailazar300
Add UpdateGeneralEvent.
c834ad1
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
75a161e 
…frog-cli-security into security-error-logs-report

# Conflicts:
#	go.mod
#	go.sum
@gailazar300
Set environments variables for analyzer manager.
f9c9c0e
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
3c616d1 
…frog-cli-security into security-error-logs-report
@gailazar300
Add tests.
a4f0534
@gailazar300
Remove error handling for analytics.
abc6553
@gailazar300
Change AnalyticsMetricsService creation.
e79cb1e
@gailazar300
Merge remote-tracking branch 'upstream/dev' into feature/XRAY-36905
b45d003 
# Conflicts:
#	go.sum
@gailazar300
go.mod+sum
b3452da
@gailazar300
Minor fixes.
fdb5051
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
1abd3d1 
…frog-cli-security into security-error-logs-report

# Conflicts:
#	go.mod
#	go.sum
@gailazar300
Review fixes.
4c68943
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
18cb1bc 
…frog-cli-security into security-error-logs-report
@gailazar300
Add integration test.
2c9fcba
@gailazar300
Minor fixes.
fc0f2df
@eranturgeman
report error to coralogix initial push
610af6d
@eranturgeman eranturgeman marked this pull request as draft April 1, 2024 14:47
eranturgeman and others added 9 commits April 2, 2024 09:50
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
ca2c92f 
…frog-cli-security into security-error-logs-report

# Conflicts:
#	go.mod
#	go.sum
@gailazar300
Change add general event flow for Frogbot.
b9560da
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
3c2043a 
…frog-cli-security into security-error-logs-report
@gailazar300
Second review fixes.
040ce9b
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
ad4855a 
…frog-cli-security into security-error-logs-report
@gailazar300
Remove Frogbot's MSI validation - there is no common flow for cli and…
40884cb 
… Frogbot for analytics.
@gailazar300
Minor fix.
51de09a
@eranturgeman
Merge branch 'feature/XRAY-36905' of https://github.com/gailazar300/j…
15dc089 
…frog-cli-security into security-error-logs-report
@gailazar300
Minor fix.
df4ef8f
@eranturgeman eranturgeman requested a review from attiasas April 8, 2024 12:27
@eranturgeman eranturgeman added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Apr 8, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 8, 2024
@eranturgeman eranturgeman changed the title Adding error logs reports for audit scans Adding error logs report for audit scans Apr 8, 2024
attiasas
attiasas reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, check my comments.

cli/scancommands.go Outdated Show resolved Hide resolved
utils/errorreport.go Outdated Show resolved Hide resolved
utils/errorreport.go Outdated Show resolved Hide resolved
utils/errorreport_test.go Outdated Show resolved Hide resolved
utils/errorreport_test.go Outdated Show resolved Hide resolved
utils/errorreport_test.go Outdated Show resolved Hide resolved
utils/xscmanager.go Outdated Show resolved Hide resolved
utils/xscmanager.go Outdated Show resolved Hide resolved
utils/xscmanager.go Outdated Show resolved Hide resolved
@attiasas attiasas mentioned this pull request Apr 9, 2024
Merged
4 tasks
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 9, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Apr 10, 2024
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

@eranturgeman eranturgeman merged commit 35f6200 into jfrog:dev Apr 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eranturgeman @attiasas @gailazar300