Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary format #63

Merged
merged 45 commits into from
May 22, 2024
Merged

Add summary format #63

merged 45 commits into from
May 22, 2024

Conversation

attiasas
Copy link
Contributor

@attiasas attiasas commented May 9, 2024

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This PR depends on: jfrog/jfrog-cli-core#1179

This PR adds the following:

  • Summary information for results on security commands (not visible but could be added as a new format with little effort)
  • A capability for scan commands (jf scan, jf docker-scan, jf build-scan) to generate a Job summary if running on Github actions. (This option could be added to audit as well if needed)

image
If only one type of security command is used the titles will not be visible.

If only one security command on one target is used it will show the following:

image
image

@attiasas attiasas added the feature request New feature or request label May 9, 2024
@attiasas attiasas added new feature Automatically generated release notes and removed feature request New feature or request labels May 12, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 19, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 19, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 19, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 21, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 21, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label May 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label May 22, 2024
@attiasas attiasas merged commit 3e9fe2d into jfrog:dev May 22, 2024
6 of 9 checks passed
@attiasas attiasas deleted the add_summary_format branch May 22, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants