Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GolangCI static checks action and fix all found issues #2011

Merged
merged 19 commits into from
Jun 14, 2023
Merged

Add GolangCI static checks action and fix all found issues #2011

merged 19 commits into from
Jun 14, 2023

Conversation

sverdlov93
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@sverdlov93 sverdlov93 requested review from eyalbe4 and yahavi June 1, 2023 17:05
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 1, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 1, 2023
yahavi
yahavi requested changes Jun 13, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing piece of code @sverdlov93!
Please consider my inline comments.

buildinfo_test.go Outdated Show resolved Hide resolved
docker_test.go Outdated Show resolved Hide resolved
general/cisetup/cisetup.go Outdated Show resolved Hide resolved
general/cisetup/cisetup.go Outdated Show resolved Hide resolved
general/cisetup/cisetup.go Outdated Show resolved Hide resolved
utils/progressbar/readerprogressbar.go Outdated Show resolved Hide resolved
utils/progressbar/simpleprogressbar.go Outdated Show resolved Hide resolved
utils/summary/summary.go Outdated Show resolved Hide resolved
xray_test.go Outdated Show resolved Hide resolved
xray_test.go Outdated Show resolved Hide resolved
@sverdlov93 @yahavi
Update docker_test.go
393292f 
Co-authored-by: Yahav Itzhak <[email protected]>
@sverdlov93 @yahavi
Update gradle_test.go
592086c 
Co-authored-by: Yahav Itzhak <[email protected]>
@sverdlov93 @yahavi
Update gradle_test.go
eb24806 
Co-authored-by: Yahav Itzhak <[email protected]>
sverdlov93
sverdlov93 commented Jun 13, 2023
View reviewed changes
xray_test.go Outdated Show resolved Hide resolved
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 13, 2023
@sverdlov93 sverdlov93 merged commit 37d3e4a into jfrog:dev Jun 14, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi requested changes

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @yahavi