Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip-folders flag #2035

Closed
wants to merge 2 commits into from
Closed

skip-folders flag #2035

wants to merge 2 commits into from

Conversation

orto17
Copy link
Contributor

@orto17 orto17 commented Jun 20, 2023

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

The purpose of this PR:

  • Adding a new flag: "skip-folders" to the audit command.
  • This flag determines which folders will not be scanned by Jas scanners.
  • When the user is not using this flag, the default value is (same as in vs code): "/test/", "/venv/", "/node_modules/", "/target/"

@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Jun 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 20, 2023
@eyalbe4
Copy link
Contributor

eyalbe4 commented Jun 20, 2023

@orto17 -
Will you be able to add a clear description for this PR, so that everyone understands its goals and function?
Sage goes for jfrog/jfrog-cli-core#832.
These PRs receive hight visibility and should therefore be clear for all readers.

@orto17 orto17 added the safe to test Approve running integration tests on a pull request label Jun 20, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jun 20, 2023
@talarian1 talarian1 self-requested a review June 20, 2023 11:16
@talarian1 talarian1 closed this Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants