New --module option added to the build-add-dependencies command
#2081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sarao1310
commented
Jul 17, 2023
•
sarao1310
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- All static analysis checks passed.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
sarao1310
changed the title
sarao1310
added
safe to test
sarao1310
changed the title
sarao1310
added
improvement
github-actions
bot
removed
the
safe to test
sarao1310
added
the
safe to test
github-actions
bot
removed
the
safe to test
eyalbe4
changed the title
build-add-dependencies command
eyalbe4
changed the title
build-add-dependencies command--module option added to the build-add-dependencies command
github-actions
bot
removed
the
safe to test
eyalbe4
requested changes
Jul 27, 2023
| @@ -893,6 +893,7 @@ By default, the command collects the files from the local file system. If you'd | |||
| | --recursive | \[Default: true\]<br><br>When false, artifacts inside sub-folders in Artifactory will not be affected. | | |||
| | --regexp | \[Optional: false\]<br><br>\[Default: false\] Set to true to use a regular expression instead of wildcards expression to collect files to be added to the build info.This option is not supported when --from-rt is set to true. | | |||
| | --dry-run | \[Default: false\]<br><br>Set to true to only get a summery of the dependencies that will be added to the build info. | | |||
| | --module | \[Optional\]<br><br>Optional module name for the build-info. | | |||
There was a problem hiding this comment.
Optional module name for the build-info.
-->
Optional module name in the build-info for adding the depedency
(let's ensure to use the same phrasing for the embedded CLI help as well).
sarao1310
added
the
safe to test
github-actions
bot
removed
the
safe to test
# Conflicts: # go.mod # go.sum
sarao1310
added
the
safe to test
github-actions
bot
removed
the
safe to test
sarao1310
added
the
safe to test
github-actions
bot
removed
the
safe to test
sarao1310
added
the
safe to test
github-actions
bot
removed
the
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.