Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go.mod and go.sum with the latest jfrog-client-go #2670

Closed
wants to merge 1 commit into from
Closed

Update go.mod and go.sum with the latest jfrog-client-go #2670

wants to merge 1 commit into from

Conversation

Or-Geva
Copy link
Contributor

@Or-Geva Or-Geva commented Aug 28, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

Related PR:
jfrog/jfrog-client-go#1007

@Or-Geva Or-Geva added feature request New feature or request safe to test Approve running integration tests on a pull request labels Aug 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 28, 2024
@Or-Geva Or-Geva added safe to test Approve running integration tests on a pull request ignore for release Automatically generated release notes and removed feature request New feature or request safe to test Approve running integration tests on a pull request labels Aug 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 28, 2024
@Or-Geva Or-Geva added the safe to test Approve running integration tests on a pull request label Aug 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Aug 28, 2024
@Or-Geva Or-Geva requested a review from omerzi August 28, 2024 06:38
omerzi
omerzi reviewed Aug 28, 2024
View reviewed changes
go.mod
// replace github.com/jfrog/jfrog-cli-core/v2 => github.com/eyalbe4/jfrog-cli-core/v2 v2.55.3-0.20240821161232-d9ee8b2b6e9c

// replace github.com/jfrog/jfrog-client-go => github.com/jfrog/jfrog-client-go v1.28.1-0.20240806162439-01bb7dcd43fc
// replace github.com/jfrog/jfrog-cli-core/v2 => github.com/jfrog/jfrog-cli-core/v2 dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace core as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do it because it causes breaking changes.

@Or-Geva
Copy link
Contributor Author

Or-Geva commented Aug 28, 2024

Since we can't update the core due to the following, we are closing this PR, not to have different client version than the core have:
Error:

go: finding module for package github.com/jfrog/jfrog-cli-core/v2/commandsummary
go: github.com/jfrog/jfrog-cli/utils/cliutils imports
        github.com/jfrog/jfrog-cli-core/v2/commandsummary: module github.com/jfrog/jfrog-cli-core/v2@latest found (v2.55.4, replaced by github.com/jfrog/jfrog-cli-core/[email protected]), but does not contain package github.com/jfrog/jfrog-cli-core/v2/commandsummary
        ```

@Or-Geva Or-Geva closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerzi omerzi omerzi left review comments

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Or-Geva @omerzi