EOS - Add Rule ID (#32)

jfrog · Aug 6, 2023 · 655180d · 655180d
1 parent 04448d5
commit 655180d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/src/components/Page/Eos/Eos.test.tsx b/src/components/Page/Eos/Eos.test.tsx
@@ -16,6 +16,7 @@ describe('Eos component', () => {
 			endRow: 1,
 			endColumn: 10
 		},
+		ruleId: 'ruleId-1',
 		description: 'Description example',
 		remediation: ['Remediation 1', 'Remediation 2'],
 		foundText: 'Found text example',
@@ -38,6 +39,7 @@ describe('Eos component', () => {
 			}
 		]
 	}
+
 	test('renders header', () => {
 		const { getByText } = render(<Eos data={mockData} />)
 		const headerElement = getByText('Header example')
@@ -65,6 +67,12 @@ describe('Eos component', () => {
 		expect(getByText('Description example')).toBeInTheDocument()
 	})
 
+	test('renders rule id', () => {
+		const { getByText } = render(<Eos data={mockData} />)
+		const severityElement = getByTextAcrossMultipleElements(getByText, 'Rule ID: ruleId-1')
+		expect(severityElement).toBeInTheDocument()
+	})
+
 	test('renders remediation 1', () => {
 		const { getByText } = render(<Eos data={mockData} />)
 		expect(getByText('DESCRIPTION')).toBeInTheDocument()

diff --git a/src/components/Page/Eos/Eos.tsx b/src/components/Page/Eos/Eos.tsx
@@ -8,6 +8,7 @@ import Research from './Research'
 import ContextualAnalysis from './ContextualAnalysis'
 import Severity from '../../UI/Summary/Severity'
 import { IEosPage } from '../../../model/webviewPages'
+import Row from '../../UI/Row/Row'
 
 export interface Props {
 	data: IEosPage
@@ -25,6 +26,7 @@ export default function Eos(props: Props): JSX.Element {
 				<Vulnerability location={`${props.data.location.file}`} />
 				<Severity severity={props.data.severity ? props.data.severity : ISeverity.Unknown} />
 				<VulnerabilityLine line={`${props.data.location.startRow}`} />
+				{!!props.data.ruleId && <Row title="Rule ID" data={props.data.ruleId} />}
 			</Summary>
 			<Research description={props.data.description} remediation={props.data.remediation} />
 			<ContextualAnalysis

diff --git a/src/components/UI/Summary/Summary.module.css b/src/components/UI/Summary/Summary.module.css
@@ -8,7 +8,6 @@
 }
 
 .halfText {
-	max-height: 5em;
 	line-height: 22px;
 	overflow: hidden;
 	transition: max-height 1s ease-out;

diff --git a/src/model/webviewPages.ts b/src/model/webviewPages.ts
@@ -57,6 +57,7 @@ export interface IEosPage {
 	foundText?: string
 	analysisStep?: IAnalysisStep[]
 	severity?: ISeverity
+	ruleId?: string
 }
 
 export interface IIaCPage {