Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release workflow #42

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Add release workflow #42

wants to merge 19 commits into from

Conversation

kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Sep 29, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • Added a release workflow to build, package, and publish the extension to the Visual Studio Marketplace.
  • Separated the build workflow to enable reuse by other workflows.
  • Removed RELEASE.md file as it is no longer necessary.
  • Added unit tests for automation scripts.
  • Added PublishManifest.json file that defines the released extension details to be viewed in the Visual Studio Marketplace.

@kerenr-jfrog kerenr-jfrog added dependencies Pull requests that update a dependency file safe to test Approve running integration tests on a pull request labels Sep 29, 2024
attiasas
attiasas requested changes Sep 30, 2024
View reviewed changes
Copy link

@attiasas attiasas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

  1. Please add tests for the scripts as well
  2. Please add static-analysis (linter)
  3. Update release wiki
  4. Make sure CLA passes

scripts/UpdateVsixVersion.ps1 Outdated Show resolved Hide resolved
scripts/UpdateVsixVersion.ps1 Show resolved Hide resolved
.github/workflows/tests.yml Show resolved Hide resolved
.github/workflows/build-vsix.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@attiasas attiasas added ignore for release Automatically generated release notes and removed dependencies Pull requests that update a dependency file labels Sep 30, 2024
@jfrog jfrog deleted a comment from github-actions bot Sep 30, 2024
@attiasas attiasas marked this pull request as ready for review October 1, 2024 12:11
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hadarshjfrog hadarshjfrog Awaiting requested review from hadarshjfrog

@attiasas attiasas Awaiting requested review from attiasas

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerenr-jfrog @attiasas