Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

token validation feature in ide #496

Merged
merged 10 commits into from
Nov 12, 2024
Merged

token validation feature in ide #496

merged 10 commits into from
Nov 12, 2024

Conversation

barv-jfrog
Copy link
Contributor

@barv-jfrog barv-jfrog commented Sep 10, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Description:
Token validation feature the same in CLI just for ide.
Depends on PRs:
jfrog/jfrog-ide-webview#62
jfrog/jfrog-client-js#96

@barv-jfrog barv-jfrog requested a review from attiasas September 10, 2024 12:45
@hadarshjfrog hadarshjfrog self-assigned this Sep 11, 2024
@attiasas attiasas added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 17, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 17, 2024
attiasas
attiasas previously requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!, Take a look at my comments.
Make sure tests are running and passing after pointing to the dependent PR's

package.json Show resolved Hide resolved
src/main/connect/connectionManager.ts Show resolved Hide resolved
src/main/connect/connectionManager.ts Outdated Show resolved Hide resolved
src/main/scanLogic/scanRunners/analyzerManager.ts Outdated Show resolved Hide resolved
src/main/scanLogic/scanRunners/analyzerManager.ts Outdated Show resolved Hide resolved
src/main/scanLogic/scanRunners/analyzerModels.ts Outdated Show resolved Hide resolved
@attiasas attiasas added the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 4, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
eyalk007
eyalk007 reviewed Nov 12, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@barv-jfrog barv-jfrog added the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

@eyalk007 eyalk007 dismissed attiasas’s stale review November 12, 2024 09:56

assafa approved

@eyalk007 eyalk007 merged commit 3edf9ff into jfrog:master Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalk007 eyalk007 eyalk007 left review comments

@attiasas attiasas attiasas left review comments

Assignees

@hadarshjfrog hadarshjfrog

Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@barv-jfrog @attiasas @eyalk007 @hadarshjfrog