Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Applicability evidence to non-applicable vulnerabilities #497

Merged
merged 12 commits into from
Nov 20, 2024
Merged

Add Applicability evidence to non-applicable vulnerabilities #497

merged 12 commits into from
Nov 20, 2024

Conversation

dortam888
Copy link
Contributor

@dortam888 dortam888 commented Sep 15, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Add Applicability evidence logic to non-applicable vulnerabilities. So far we had applicability evidence only for applicable status. Added the logic that non-applicable will also send API to webview to show.

Linked to webview fix: jfrog/jfrog-ide-webview#63

@dortam888 dortam888 mentioned this pull request Sep 19, 2024
Merged
@dortam888 dortam888 requested a review from attiasas September 19, 2024 00:27
@attiasas attiasas added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Sep 22, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Sep 22, 2024
attiasas
attiasas reviewed Sep 22, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, check out my comments

src/main/scanLogic/scanRunners/applicabilityScan.ts Outdated Show resolved Hide resolved
src/main/scanLogic/scanRunners/applicabilityScan.ts Outdated Show resolved Hide resolved
src/main/treeDataProviders/issuesTree/descriptorTree/projectDependencyTreeNode.ts Outdated Show resolved Hide resolved
src/main/treeDataProviders/utils/analyzerUtils.ts Outdated Show resolved Hide resolved
src/main/treeDataProviders/utils/analyzerUtils.ts Outdated Show resolved Hide resolved
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Oct 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 7, 2024
@dortam888 dortam888 requested a review from attiasas October 7, 2024 17:43
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Oct 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 7, 2024
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Oct 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 7, 2024
attiasas
attiasas requested changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests cases for CVE that are not applicable/not applicable

src/main/scanLogic/scanRunners/applicabilityScan.ts Outdated Show resolved Hide resolved
src/main/treeDataProviders/utils/analyzerUtils.ts Show resolved Hide resolved
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Oct 15, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 15, 2024
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 28, 2024
@dortam888 dortam888 added the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 18, 2024
@dortam888 dortam888 requested a review from attiasas November 18, 2024 13:53
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and did not find any new security issues.

attiasas
attiasas approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@attiasas attiasas merged commit d7825a7 into jfrog:master Nov 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dortam888 @attiasas