Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce isHeaderPngAccessible() timeout #235

Merged
merged 9 commits into from
Dec 26, 2024
Merged

Reduce isHeaderPngAccessible() timeout #235

merged 9 commits into from
Dec 26, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Dec 15, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

To optimize performance, this PR modifies the process for checking internet availability for the header image. Instead of performing the check repeatedly, the availability is now verified only once, with a reduced timeout to minimize delays.

@EyalDelarea EyalDelarea linked an issue Dec 15, 2024 that may be closed by this pull request
Make isHeaderPngAccessible() toggleable for offline environments #226
Closed
@EyalDelarea EyalDelarea mentioned this pull request Dec 15, 2024
Closed
@EyalDelarea EyalDelarea marked this pull request as ready for review December 15, 2024 17:28
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
@EyalDelarea EyalDelarea added improvement Automatically generated release notes safe to test Approve running integration tests on a pull request labels Dec 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 16, 2024
ccano2011
ccano2011 approved these changes Dec 16, 2024
View reviewed changes
Copy link

@ccano2011 ccano2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a much better option, thanks :)

eyalbe4
eyalbe4 requested changes Dec 26, 2024
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
src/utils.ts Outdated Show resolved Hide resolved
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Dec 26, 2024
@EyalDelarea EyalDelarea merged commit c8a1753 into jfrog:master Dec 26, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 requested changes

@hazeltonl hazeltonl hazeltonl approved these changes

@ccano2011 ccano2011 ccano2011 approved these changes

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make isHeaderPngAccessible() toggleable for offline environments
4 participants
@EyalDelarea @eyalbe4 @ccano2011 @hazeltonl