Allow configuration of asset path. #2577
Open
+17
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraggerfox
force-pushed
the
allow-configuring-asset-path
branch
from
8fd844c to
c6a688f
Compare
fraggerfox
force-pushed
the
allow-configuring-asset-path
branch
from
c6a688f to
15cd81e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to override the default configuration of the asset path which is
publicby default.If no value is set, this defaults to
publicand does not change existing behavior and will preserve backward compatibility.New().While here also replace the deprecated
ioutil.TempFile()withos.CreateTemp().