Use only VIN as DeviceInfo.identifiers #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the config entry version to 2, which will initiate an entry migration. If the device is in the simplest broken state, then all it will do is rewrite the device identifiers to use
vin.If the devices were already conflated, especially if you had 2 or more teslafi accounts added, then it's possible that it might need to do a more destructive migration: deleting the old devices, disassociating it from the config entries, and then let the integration start up normally with the new VIN identifiers.
If it had to do a destructive migration, any entity overrides you may have done (like enabling one of the disabled-by-default entities, renaming an entity or entity_id, changing an icon, etc) will also be reset. However, as long as the entity id of the migrated entry still matches the original entity id, your entity history should be preserved, and any automations you already had set up should also continue to work.