Merge pull request #25111 from qmonmert/commander1200

Commander 12.0.0
jhipster · Feb 10, 2024 · ac763b9 · ac763b9
2 parents 69265fa + 3b01695
commit ac763b9
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 21 deletions.
diff --git a/cli/cli.spec.mts b/cli/cli.spec.mts
@@ -267,16 +267,16 @@ describe('cli', () => {
             description: 'Foo',
           },
           {
-            option: '--no-foo',
-            description: 'No foo',
+            option: '--qux-cd',
+            description: 'Qux cd',
           },
           {
-            option: '--foo-bar',
-            description: 'Foo bar',
+            option: '--bar',
+            description: 'Bar',
           },
           {
-            option: '--no-foo-bar',
-            description: 'No foo bar',
+            option: '--xyz-ab',
+            description: 'Xyz ab',
           },
         ],
       };
@@ -293,7 +293,7 @@ describe('cli', () => {
         commands.mocked.desc = 'Mocked command';
         commands.mocked.argument = ['<name>'];
         commands.mocked.cliOnly = true;
-        argv = ['jhipster', 'jhipster', 'mocked', 'Foo', '--foo', '--foo-bar'];
+        argv = ['jhipster', 'jhipster', 'mocked', 'Foo', '--foo', '--bar'];
       });
 
       commonTests();
@@ -302,7 +302,7 @@ describe('cli', () => {
         const cb = (args, options) => {
           expect(args).toEqual(['Foo']);
           expect(options.foo).toBe(true);
-          expect(options.fooBar).toBe(true);
+          expect(options.bar).toBe(true);
         };
         await mockCli(argv, { commands, './mocked': cb });
       });
@@ -313,16 +313,16 @@ describe('cli', () => {
         commands.mocked.desc = 'Mocked command';
         commands.mocked.argument = ['<name>'];
         commands.mocked.cliOnly = true;
-        argv = ['jhipster', 'jhipster', 'mocked', 'Foo', '--no-foo', '--no-foo-bar'];
+        argv = ['jhipster', 'jhipster', 'mocked', 'Foo', '--qux-cd', '--xyz-ab'];
       });
 
       commonTests();
 
       it('should forward argument and options', async () => {
         const cb = (args, options) => {
           expect(args).toEqual(['Foo']);
-          expect(options.foo).toBe(false);
-          expect(options.fooBar).toBe(false);
+          expect(options.foo).toBeUndefined();
+          expect(options.bar).toBeUndefined();
         };
         await mockCli(argv, { commands, './mocked': cb });
       });
@@ -333,7 +333,7 @@ describe('cli', () => {
         commands.mocked.desc = 'Mocked command';
         commands.mocked.argument = ['<name...>'];
         commands.mocked.cliOnly = true;
-        argv = ['jhipster', 'jhipster', 'mocked', 'Foo', 'Bar', '--foo', '--foo-bar'];
+        argv = ['jhipster', 'jhipster', 'mocked', 'Foo', 'Bar', '--foo', '--bar'];
       });
 
       commonTests();
@@ -342,7 +342,7 @@ describe('cli', () => {
         const cb = (args, options) => {
           expect(args).toEqual([['Foo', 'Bar']]);
           expect(options.foo).toBe(true);
-          expect(options.fooBar).toBe(true);
+          expect(options.bar).toBe(true);
         };
         await mockCli(argv, { commands, './mocked': cb });
       });
@@ -352,7 +352,7 @@ describe('cli', () => {
       beforeEach(() => {
         commands.mocked.desc = 'Mocked command';
         commands.mocked.cliOnly = true;
-        argv = ['jhipster', 'jhipster', 'mocked', '--foo', '--foo-bar'];
+        argv = ['jhipster', 'jhipster', 'mocked', '--foo', '--bar'];
       });
 
       commonTests();
@@ -361,7 +361,7 @@ describe('cli', () => {
         const cb = (args, options) => {
           expect(args).toEqual([]);
           expect(options.foo).toBe(true);
-          expect(options.fooBar).toBe(true);
+          expect(options.bar).toBe(true);
         };
         return mockCli(argv, { commands, './mocked': cb });
       });

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -125,7 +125,7 @@
     "axios": "1.6.7",
     "chalk": "5.3.0",
     "chevrotain": "11.0.3",
-    "commander": "11.1.0",
+    "commander": "12.0.0",
     "conf": "12.0.0",
     "debug": "4.3.4",
     "didyoumean": "1.2.2",