-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v7] node v18 test #20394
[v7] node v18 test #20394
Conversation
@mshima What do we need to do to make the Related: we should probably do a 7.x release that works with Node 18. |
@mraible main is supposed to work with node 18, only a wait-on (actually node) bug that requires to use the loopback ip instead of localhost name (in case ipv6 is preferred). |
We might want to release a new 7.9.x version that works with Node 18, since a lot of folks seem to be running into this issue. |
I just tried installing version 7.9.3 and using Node v18.13.0. It does not work:
This fix solved it for me. |
Maybe I spoke too soon. Both on Node v16.19.0 and with v18.13.0 (after the fix), the following happens:
This could certainly be my machine only, not sure. |
jhipster v7.9.3 is broken at node 18, fixed at jhipster:v7.x_maintenance branch. |
@mshima I'm saying v7.9.3 seems to be broken with Node 16 too. I have successfully used it with Node 16 before, so it certainly could be my machine. I just tried it with v16.19.0 and v16.17.1. Both result in the error above.
If I try |
Nevermind, these failures are happening because I'm using the |
jhipster v7 at maintenance branch works with node 18, except the broken by #21380 |
Not to be merged, this PR tests v7 branch with node 18
Related to #20349.
Please make sure the below checklist is followed for Pull Requests.
When you are still working on the PR, consider converting it to Draft (below reviewers) and adding
skip-ci
label, you can still see CI build result at your branch.