Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos #23687

Merged
merged 3 commits into from
Sep 29, 2023
Merged

Typos #23687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9934fa1
fix(typo): Runnning=>Running
qmonmert Sep 29, 2023
18d8e42
fix(typo): choosen=>chosen
qmonmert Sep 29, 2023
d4829ae
fix(typo): definiton=>definition
qmonmert Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ Go to the [generator-jhipster project](https://github.com/jhipster/generator-jhi
Since v8 `generator-jhipster` is written in typescript.
To run it you need to compile to javascript or use a just-in-time compilation.

#### Runnning jit executable
#### Running jit executable

The executable is located at `bin/jhipster.cjs`.
You can alias it to `jhipster` command:
Expand Down Expand Up @@ -339,7 +339,7 @@ Daily builds samples are prefixed with `daily-`.
#### Samples folder

A common samples folder will be used if `--global` option is used like `jhipster generate-sample ng-default --global`.
At first execution a prompt will ask for the samples folder, the choosen value will be reused at next executions.
At first execution a prompt will ask for the samples folder, the chosen value will be reused at next executions.
At samples folder, a `jhipster-samples.code-workspace` is generated. It provides a single vscode workspace for `generator-jhipster` and samples generated at the samples folder. It's very used for quick looks.

### Testing samples
Expand Down
2 changes: 1 addition & 1 deletion rfcs/5-jhipster-rfc-inclusive-property-in-generator.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ the resulting (simplified) json object used by the generator

[drawbacks]: #drawbacks

Blueprint with additional options will have to override objects definiton: an overridable api should be provided at the generator-core level to let the blueprint developer to add its own attributes at each level
Blueprint with additional options will have to override objects definition: an overridable api should be provided at the generator-core level to let the blueprint developer to add its own attributes at each level

## Rationale and alternatives

Expand Down
Loading