Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip-address configuration for Consul discovery #24984

Closed
wants to merge 1 commit into from

Conversation

yhao3
Copy link
Contributor

@yhao3 yhao3 commented Jan 28, 2024

I addressed the issue #24377 reported by @mraible. The problem was related to service checks failing when running apps without Docker. By adding the ip-address: host.docker.internal configuration in the Consul discovery section, the service check issue should be resolved.


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@yhao3 yhao3 marked this pull request as draft January 29, 2024 08:39
@yhao3
Copy link
Contributor Author

yhao3 commented Jan 29, 2024

I noticed that this modification could cause issues with Gateway when routing requests. Therefore, I've temporarily marked it as a Draft.

@yhao3 yhao3 closed this Feb 6, 2024
@deepu105 deepu105 added this to the 8.2.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants