Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client modules using typescript should depend on the typescript module #10421

Open
2 of 4 tasks
murdos opened this issue Jul 27, 2024 · 1 comment
Open
2 of 4 tasks

Client modules using typescript should depend on the typescript module #10421

murdos opened this issue Jul 27, 2024 · 1 comment

Comments

@murdos
Copy link
Contributor

murdos commented Jul 27, 2024

Following a recent discussion on the addition of new modules adding typescript utilities, it demonstrates that we currently have an issue regarding typescript related modules.

Let's pick the optional-typescript as an example: it requires the typescript.
So if you have applied for example the vue-core module, you can't use it unless you also apply the typescript module which will generates conflicting npm configuration (e.g. setting up jest in addition to already setup vitest).

On the contrary the new modules, ts-loader and ts-pagination-domain only requires the init module, which is convenient for matching both use cases, but a bit wrong since code will not compile if you don't have already applied a module that'll setup typescript.

My suggestion is to rework the typescript module to make it use a modern setup (eslint, vitest), and have at least vue-core and react-core modules (angular could be nice too, but it has a very specific build tools so this might be a bit more complicated) depend on the typescript module.

image

@pascalgrimaud @qmonmert @DamnClin @renanfranca : WDYT?

Related: #3979

@renanfranca
Copy link
Contributor

I agree with this 💯 👌. It will help new frontend devs 😁👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants