refactor(client-common): remove ClientsModulesFactory that was only containing lintstaged configuration #10450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontaining lintstaged configuration ClientsModulesFactory was previously doing more things, but it now only append lintstaged configuration. By moving things to each client, we can use a more fined grained configuration (e.g. vue extension only for vue client, tsx for react, ...).
murdos
commented
Jul 29, 2024
| @@ -83,7 +82,7 @@ public JHipsterModule buildModule(JHipsterModuleProperties properties) { | |||
| Assert.notNull(PROPERTIES, properties); | |||
|
|
|||
| //@formatter:off | |||
| return ClientsModulesFactory.clientModuleBuilder(properties) | |||
| return moduleBuilder(properties) | |||
There was a problem hiding this comment.
@renanfranca : I don't think this was useful for Thymeleaf, since eslint is not even a dependency, so it could be missing.
WDYT?
There was a problem hiding this comment.
That was my first issue adding the "frontend" module. I remember using lint in the generated project to help me format the template code, but I am not sure if the Client.... class helped me. However, there is a Prettier configuration in the deleted Client.... class.
Maybe I copied and pasted 🤔 and learned while doing...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClientsModulesFactory was previously doing more things, but it now only append lintstaged configuration. By moving things to each client, we can use a more fined grained configuration (e.g. vue extension only for vue client, tsx for react, ...).
Preparation for #10421