Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the svelte module #10910

Open
murdos opened this issue Sep 19, 2024 · 10 comments · May be fixed by #10958
Open

Remove the svelte module #10910

murdos opened this issue Sep 19, 2024 · 10 comments · May be fixed by #10958

Comments

@murdos
Copy link
Contributor

murdos commented Sep 19, 2024

This module has been unmaintained for months, and is already disabled.

We should remove the code since it still add some maintenance burden, and the outdated src/main/resources/generator/dependencies/svelte/package.json contains dependencies with security issues.

@pascalgrimaud
Copy link
Member

Little bit sad as it was a good opportunity to have a good architecture with a modular approach

But I understand and respect @vishal423 as he prefers maintaining https://github.com/jhipster/generator-jhipster-svelte

So yes, let's remove it

@vishal423
Copy link

What exactly do we require for svelte maintenance?

@murdos
Copy link
Contributor Author

murdos commented Sep 19, 2024

@vishal423 : e.g. updating the code to follow generator best/new practices: https://github.com/jhipster/jhipster-lite/commits/8b97ff3836cf8669e6e74d32a04daa04c4846419/src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java

It's also the only client module that has not moved to Eslint 9, Prettier 3, and does not use recent versions of vite and vitest, ...

@vishal423
Copy link

Do you mean files under src/main/java/tech/jhipster/lite/generator/client/svelte/core?

@murdos
Copy link
Contributor Author

murdos commented Sep 19, 2024

@vishal423 : Sorry, I misunderstood the situation, I thought that you were the original author of the svelte module in jhipster-lite, and thus that you were familiar with the code 😅

I think there are some technical debt around generated tooling (prettier, eslint, maybe vite and vitest), and the migration from svelte 3 to 4.
Once this is done, the maintenance would be very low I guess because the generated content is very minimal, mainly handle breaking svelte changes.

Would you agree to help doing the svelte specific parts? If so, I could handle the tooling upgrade.
WDYT?

@vishal423
Copy link

Since I never contributed to this project before, I may need some time to setup local env and try out the code-gen. Further, frontend is a hobby work for me and lately got little time to contribute. I can't commit anything at this moment.

@pascalgrimaud
Copy link
Member

Prerequisites are Java 21, Node LTS and git
It's similar to what generates classic generator-jhipster, so it's easy to setup

So take your time, no worry

@murdos : so let's wait a little bit, before thinking about removing this module

@vishal423
Copy link

how to view svelte option in UI to generate code?

@murdos
Copy link
Contributor Author

murdos commented Sep 21, 2024

@vishal423 : it's currently hidden, you can re-enable it by removing this configuration parameter:

@vishal423
Copy link

thanks. I am able to generate. Few questions:

  • Can I disable typescript?
  • Can I generate unit tests side by side for the frontend code?
  • I could see App.svelte the only file in the generated application. Is that all we have built with svelte?

@vishal423 vishal423 linked a pull request Sep 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants