feat: Upgrade and enable svelte-core module #10958
Conversation
src/main/resources/generator/client/svelte/src/main/webapp/app.html.mustache
Outdated
Show resolved
Hide resolved
| .addScript(scriptKey("test"), scriptCommand("npm run test:watch")) | ||
| .addScript(scriptKey("test:coverage"), scriptCommand("vitest run --coverage")) | ||
| .addScript(scriptKey("test:watch"), scriptCommand("vitest --")) | ||
| .addScript(scriptKey("check"), scriptCommand("svelte-kit sync && svelte-check --tsconfig ./jsconfig.json")) |
There was a problem hiding this comment.
I think we should keep the script structure from angular/react/vue modules (to be able to use TikUi)
There was a problem hiding this comment.
Feel free to push changes to this branch, as needed.
There was a problem hiding this comment.
I won't :). Those scripts needs to be updated otherwise it will break the current work on frontend modules and we won't be able to integrate styles in svelte and svelte module will be broken, again.
I don't care about svelte integration so I won't contribute on that but I do care about frontend modules moving forward :)
There was a problem hiding this comment.
@DamnClin : Don't worry, I'll take the charge of harmonizing the svelte client with other clients :) @vishal423 is helping us here to bring back the svelte client to life ;)
| public JHipsterModule buildSvelteModule(JHipsterModuleProperties properties) { | ||
| Assert.notNull("properties", properties); | ||
|
|
||
| //@formatter:off | ||
| return moduleBuilder(properties) | ||
| .preCommitActions(stagedFilesFilter("{src/**/,}*.ts"), preCommitCommands("eslint --fix", "prettier --write")) |
There was a problem hiding this comment.
I think we should keep typescript.
Enforcing a strongly typed language, that allows Type Driven Development, is one of the opinionated view of jhipster-lite.
There was a problem hiding this comment.
feel free to push changes, as needed
| public JHipsterModule buildSvelteModule(JHipsterModuleProperties properties) { | ||
| Assert.notNull("properties", properties); | ||
|
|
||
| //@formatter:off | ||
| return moduleBuilder(properties) | ||
| .preCommitActions(stagedFilesFilter("{src/**/,}*.ts"), preCommitCommands("eslint --fix", "prettier --write")) | ||
| .preCommitActions(stagedFilesFilter("{src/**/,}*.{js,svelte}"), preCommitCommands("eslint --fix", "prettier --write", "npm run check")) |
There was a problem hiding this comment.
On other client in jhipster-lite, the pre-commit action doesn't check, it just fixes/reformat.
There was a problem hiding this comment.
invocation of eslint --fix implicitly checks for lint errors and resolves whatever it can. If you still have lint errors, then, I believe it print those on console and aborts the commit. Inclusion of svelte check is to avoid commit of erroneous svelte code.
| .addScript(scriptKey("test:watch"), scriptCommand("vitest --")) | ||
| .addScript(scriptKey("check"), scriptCommand("svelte-kit sync && svelte-check --tsconfig ./jsconfig.json")) | ||
| .addScript(scriptKey("lint"), scriptCommand("prettier --check . && eslint .")) | ||
| .addScript(scriptKey("format"), scriptCommand("prettier --write '{,src/**/,cypress/**/}*.{md,json,js,cjs,svelte,css,html,yml}'")) |
There was a problem hiding this comment.
The svelte module already depends on the prettier module, that setup a prettier:format script, so there's no need to add a new script for formatting.
There was a problem hiding this comment.
Since we use a different pattern in pre-commit hook, this script allows reuse of same for explicit invocation
src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java
Outdated
Show resolved
Hide resolved
| @@ -17,96 +18,108 @@ public class SvelteModuleFactory { | |||
|
|
|||
| private static final String ENGINES_NEEDLE = " \"engines\":"; | |||
|
|
|||
| private static final JHipsterSource PRIMARY_MAIN_SOURCE = SOURCE.append("src/main/webapp/app/common/primary/app"); | |||
| private static final JHipsterDestination PRIMARY_MAIN_DESTINATION = to("src/main/webapp/app/common/primary/app"); | |||
| private static final JHipsterSource PRIMARY_MAIN_SOURCE = SOURCE.append("src/main/webapp/lib/common/primary/app"); | |||
There was a problem hiding this comment.
I think we should keep things in the app folder: other modules (e.g. ts-pagination-domainà that generates additional content will generate content in the app folder.
There was a problem hiding this comment.
technically it's internal lib containing app specific components. feel free to update, if needed
src/main/java/tech/jhipster/lite/generator/client/svelte/core/domain/SvelteModuleFactory.java
Outdated
Show resolved
Hide resolved
murdos
added
area: feature request 💡
client: svelte
theme: client
and removed
area: triage
labels
….html.mustache Co-authored-by: Quentin <[email protected]>
…domain/SvelteModuleFactory.java Co-authored-by: Aurélien Mino <[email protected]>
…t has been added to prettier module
murdos
force-pushed
the
enable-svelte-module
branch
from
4e12210
to
03d014d
Compare
closes #10910