Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sonarqube v10.7.0 #11035

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Upgrade sonarqube v10.7.0 #11035

merged 1 commit into from
Oct 3, 2024

Conversation

qmonmert
Copy link
Contributor

@qmonmert qmonmert commented Oct 2, 2024

Fix #11034

@qmonmert qmonmert force-pushed the sonarqube1070 branch 6 times, most recently from aea3f19 to 1501279 Compare October 2, 2024 20:33
@qmonmert qmonmert marked this pull request as ready for review October 2, 2024 20:53
@@ -79,3 +81,7 @@ sonar.issue.ignore.multicriteria.S6437.ruleKey=java:S6437
# Rule: Run container as default user
sonar.issue.ignore.multicriteria.S6471.resourceKey=src/main/docker/cassandra/**/*
sonar.issue.ignore.multicriteria.S6471.ruleKey=docker:S6471

# Rule: Methods should not contain selector parameters
sonar.issue.ignore.multicriteria.S2301.resourceKey=src/main/webapp/**/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should disable this valid rule on our whole source code: https://sonarsource.github.io/rspec/#/rspec/S2301
Either we fix the code, or we specifically disable it for the problematic code.

@murdos murdos merged commit a3a1a41 into jhipster:main Oct 3, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants