Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: packages/alice_chopper non-HTTP error status #200

Merged
merged 1 commit into from
Jun 22, 2024
Merged

fix: packages/alice_chopper non-HTTP error status #200

merged 1 commit into from
Jun 22, 2024

Conversation

techouse
Copy link
Collaborator

@techouse techouse commented Jun 16, 2024

I noticed that the AliceHttpResponse.status has to be -1 to show ERR in the calls list UI.

image

@techouse techouse changed the title fix: alice_chopper error status fix: packages/alice_chopper error status Jun 16, 2024
@techouse techouse changed the title fix: packages/alice_chopper error status fix: packages/alice_chopper non-HTTP-error status Jun 16, 2024
@techouse techouse changed the title fix: packages/alice_chopper non-HTTP-error status fix: packages/alice_chopper non-HTTP error status Jun 16, 2024
@jhomlala
Copy link
Owner

LGTM :)

@jhomlala jhomlala merged commit 7eace3e into jhomlala:master Jun 22, 2024
2 checks passed
@techouse techouse deleted the fix/packages/alice_chopper/alice-response-error-status branch June 22, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants