Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix #228 AliceCallsListPage String? unwrap #229

Merged
merged 2 commits into from
Sep 29, 2024
Merged

fix: fix #228 AliceCallsListPage String? unwrap #229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db14e24
fix: fix #228 AliceCallsListPage String? unwrap
techouse Aug 19, 2024
555e914
Merge branch 'master' into fix/issue-228-unwrap-path
jhomlala Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/alice/lib/ui/calls_list/page/alice_calls_list_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,11 +255,10 @@ class _AliceCallsListPageState extends State<AliceCallsListPage>

/// Called when save to file has been pressed. It saves data to file.
void _saveToFile() async {
if (!mounted) return;
final result = await aliceCore.saveCallsToFile(context);

if (!mounted) return;

if (result.success) {
if (result.success && result.path != null) {
AliceGeneralDialog.show(
context: context,
title: context.i18n(AliceTranslationKey.saveSuccessTitle),
Expand All @@ -270,7 +269,7 @@ class _AliceCallsListPageState extends State<AliceCallsListPage>
? context.i18n(AliceTranslationKey.saveSuccessView)
: null,
secondButtonAction: () =>
OperatingSystem.isAndroid ? OpenFilex.open(result.path) : null,
OperatingSystem.isAndroid ? OpenFilex.open(result.path!) : null,
);
} else {
final [String title, String description] = switch (result.error) {
Expand Down
Loading