New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix-dio-query-parameters #239

Open

EArminjon wants to merge 1 commit into jhomlala:master from EArminjon:fix-dio-query-parameters

EArminjon commented Sep 19, 2024 •

edited

Loading

options.queryParameters is used by Dio to offer an entrypoint for developpers to give query parameters easily.

options.queryParameters didn't contain queryParameters put inside path string :

Dio().get(
  "https://test.com/home?test=youWillNotSeeMe", 
  queryParameters: {
    "test2: youWillSeeMe",
  },
);

uri.queryParameters contain both (path.queryParameters and options.queryParameters). This PR fix that and this issue : #237


          fix-dio-query-parameters

1516b77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet