Skip to content

Commit

Permalink
Bug fix: GitHub action changes
Browse files Browse the repository at this point in the history
- Update: GitHub deprecated certain actions that were being used by our actions: https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/. Even though they were just deprecated, it caused an error from our actions still being on the old version.
  • Loading branch information
joeflack4 committed Sep 25, 2024
1 parent 84a9f9d commit 8ce3bac
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/backend_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
# run: python -m unittest discover -v
# About: https://azure.github.io/AppService/2020/12/11/cicd-for-python-apps.html
- name: Upload artifact for deployment jobs
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: python-app
path: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/backend_prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
# run: python -m unittest discover -v
# About: https://azure.github.io/AppService/2020/12/11/cicd-for-python-apps.html
- name: Upload artifact for deployment jobs
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: python-app
path: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_frontend_e2e_live_dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
# Run tests
- name: Run Playwright tests
run: make test-frontend-e2e-dev
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
# run: yarn playwright install --with-deps # Use yarn to run playwright install
# - name: Run Playwright tests
# run: yarn playwright test # Use yarn to run playwright test
# - uses: actions/upload-artifact@v3
# - uses: actions/upload-artifact@v4
# if: always()
# with:
# name: playwright-report
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
# Run tests
- name: Run Playwright tests
run: make test-frontend-e2e-dev
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down Expand Up @@ -82,7 +82,7 @@ jobs:
# run: yarn playwright install --with-deps # Use yarn to run playwright install
# - name: Run Playwright tests
# run: yarn playwright test # Use yarn to run playwright test
# - uses: actions/upload-artifact@v3
# - uses: actions/upload-artifact@v4
# if: always()
# with:
# name: playwright-report
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test_frontend_e2e_live_prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
# Run tests
- name: Run Playwright tests
run: make test-frontend-e2e-prod
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
Expand Down Expand Up @@ -84,7 +84,7 @@ jobs:
# run: yarn playwright install --with-deps # Use yarn to run playwright install
# - name: Run Playwright tests
# run: yarn playwright test # Use yarn to run playwright test
# - uses: actions/upload-artifact@v3
# - uses: actions/upload-artifact@v4
# if: always()
# with:
# name: playwright-report
Expand Down

0 comments on commit 8ce3bac

Please sign in to comment.