Merge pull request #984 from jhu-bids/fix-e2e

Bug fix: Playwright tests

.github/workflows/test_frontend_e2e_live_dev_running_local.yml

@@ -18,6 +18,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
+      # todo: consider removing this line. It may just be redundant / non-beneficial. I had just wanted to run this on a PR branch, but it didn't work because it is fixed to `develop`
       with:
         ref: develop
 

.gitignore

@@ -53,8 +53,8 @@ node_modules
 /frontend/test-results/
 /frontend/playwright-report/
 /frontend/playwright/.cache/
-/frontend/tests/performance/*
-!/frontend/tests/performance/.keep
+/frontend/tests/playwright/performance/*
+!/frontend/tests/playwright/performance/.keep
 # production
 /build
 # misc

frontend/tests/playwright/basic-functions.test.js

@@ -86,7 +86,7 @@ for (const envName in selectedConfigs) {
     await firstRow.click();
 
     // Compare
-    await page.getByRole('link', { name: 'Cset comparison' }).click();
+    await page.getByRole('link', { name: 'Analyze and author' }).click();
     // await expect(page).toHaveURL(`${appUrl}/cset-comparison?${codeset_ids.map(d => 'codeset_ids='+d).join('&')}`);
     // that broke because there's other stuff in query string
 

frontend/tests/playwright/large-cset-handling.test.js

@@ -144,8 +144,7 @@ for (const envName in configsToRun) {
       testInfo.attach('report', {body: JSON.stringify(report), contentType: 'application/json'});
 
       // page.setDefaultTimeout(120000); // already did this, but maybe it needs doing again? or not?
-
-      const compPageLink = await page.waitForSelector('[data-testid="Cset comparison"]');
+      const compPageLink = await page.waitForSelector('[data-testid="Analyze and author"]');
       await compPageLink.click();
       console.log('going to comparison page');
       await expect(page.locator('[data-testid=comp-page-loading]')).toBeAttached({timeout: timeoutSeconds * 1000});