Mitigate proliferation of idle connections: SqlAlchemy Con --> Engine #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update: Usage of SqlAlchemy Engine instead of Connection object in order to prevent proliferation of idle connections.
joeflack4
added
refactor
Closed
2 tasks
Closed
2 tasks
joeflack4
commented
Mar 13, 2024
| } | ||
|
|
||
|
|
||
| def get_engine(isolation_level='AUTOCOMMIT', schema: str = SCHEMA, local=False): |
There was a problem hiding this comment.
get_engine()
@Sigfried Gonna just leave the work we did in this open PR. This is a low priority issue now that we've resolved the phone call in the house and also got an action that closes extra idle connections.
joeflack4
changed the title
joeflack4
force-pushed
the
develop
branch
2 times, most recently
from
d74edbe
to
155fef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Connection to Engine