'Codeless' UI test generation #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeflack4
modified the milestones:
1. Most important test issues,
2. Most important stability issues
joeflack4
commented
Sep 24, 2024
termhub-vocab
Outdated
There was a problem hiding this comment.
IDK how/why this got committed again
| ## to write tests that are theoretically compatible in any environment (as long as the UI is the same). The only | ||
| ## difference is that when the test code is written, the first line will hard-code the URL to that environment. So | ||
| ## after recording, the code should be repuprosed in the style of frontend/tests/. | ||
| codegen-local: |
There was a problem hiding this comment.
New "codeless test generation" commands
I added some documentation on how to use them and what they are in the makefile.
These are basically a wrapper for:
yarn playwright codegen URL
| @@ -0,0 +1,13 @@ | |||
| // UTILS | |||
| /* Used to convert input to be same as graphology serialization (all strings). */ | |||
| function convertToArrayOfStrings(matrix) { | |||
There was a problem hiding this comment.
Refactored this func into a tests/utils.js file
There was a problem hiding this comment.
General findings for "Codeless UI test generation"
It's not perfect. For example, I want to select something by ID or position... but when I click it using the recording feature, it gives me things like this instead:
await page.getByRole('row', { name: 'Expand Row CARDIOMYOPATHIES' })
await page.getByRole('link', { name: '12 removed , 12 added' }).click();
There are also some other caveats:
- When you copy/paste the code it generates into your test file, you should change the hard-coded URL to
appUrlinstead:await page.goto(appUrl); - It doesn't write assertions for you. You have to do that yourself.
- As shown above, oftentimes what you want (select things by ID, position) is not what it does.
joeflack4
force-pushed
the
codeless-ui-test-generation
branch
2 times, most recently
from
0608456
to
57b9bf4
Compare
- Add: Makefile commands to use 'playright codegen' - Add: New test file for N3C recommended (WIP) - Add: frontend/tests/utils.js (refactored func into here from another file)
joeflack4
force-pushed
the
codeless-ui-test-generation
branch
from
57b9bf4
to
9b718e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
'Codeless' UI test generation