-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add coursersa link to readme to check links #117
Conversation
No spelling errors! 🎉 |
|
Re-rendered previews from the latest commit:
* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea. Updated at 2024-09-17 with changes from the latest commit 043cdbf |
After commit a4dfb7f the preview rendered successfully. Double checked that the slides matched the content on the current bookdown. The title now includes ITCR in the very first slide, and there are a few slides with aesthetic rearrangements/differences, but the content is the same. The spell check is still failing so I'll try to push edits to those too. |
This url needs to be replaced: https://github.com/jhudsl/Documentation_and_Usability/blob/main/.github/workflows/url-checker.yml. But I'm not sure what to replace it with. The rest being flagged, when copy/pasted in my browser, work. |
we can push a synch from the template to here... but this is an old repo, one of the first... so @cansavvy maybe you should take a deeper look |
This looks good though besides the change in the index file for the link to the slides. Thank you very much for doing this. Could you also add yourself to the about page for these efforts... maybe as "Content Publishing Reviewers"? What do you think @cansavvy ? |
Yeah I think that's the right spot for this effort. @kweav |
As of commit d38393a, Slides Link is in the |
LGTM! the urls seem to be an artifact of maybe the newest version being still picky about parentheses etc. |
@cansavvy Is this link from the OTTR Template a good link to switch out for this broken URL? https://github.com/jhudsl/OTTR_Template/blob/main/.github/workflows/check-url.yml |
Yes that works. Thanks! |
Replace the URL checker yml link with a current one
Good to merge now? @cansavvy and @carriewright11 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @kweav !!! Super necessary and long overdue.
Want to check links, so made a token change to the README file (specifically added the coursera link for the course).