Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add coursersa link to readme to check links #117

Merged
merged 12 commits into from
Sep 17, 2024
Merged

add coursersa link to readme to check links #117

merged 12 commits into from
Sep 17, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented May 23, 2024

Want to check links, so made a token change to the README file (specifically added the coursera link for the course).

Copy link
Contributor

github-actions bot commented May 23, 2024

No spelling errors! 🎉
Comment updated at 2024-09-17-19:41:02 with changes from 043cdbf

Copy link
Contributor

github-actions bot commented May 23, 2024

⚠️ broken url errors ⚠️
There are broken url errors that need to be addressed.
Click here ➡️ for broken url errors!
Add errors that aren't errors to the resources/ignore-urls.txt file of this repo.
If you are having troubles see this guide
Comment updated at 2024-09-17-19:40:56 with changes from 043cdbf

Copy link
Contributor

github-actions bot commented May 23, 2024

Re-rendered previews from the latest commit:

* note not all html features will be properly displayed in the "quick preview" but it will give you a rough idea.

Updated at 2024-09-17 with changes from the latest commit 043cdbf

@kweav
Copy link
Contributor Author

kweav commented May 23, 2024

After commit a4dfb7f the preview rendered successfully. Double checked that the slides matched the content on the current bookdown. The title now includes ITCR in the very first slide, and there are a few slides with aesthetic rearrangements/differences, but the content is the same.

The spell check is still failing so I'll try to push edits to those too.

@kweav
Copy link
Contributor Author

kweav commented May 23, 2024

This url needs to be replaced: https://github.com/jhudsl/Documentation_and_Usability/blob/main/.github/workflows/url-checker.yml. But I'm not sure what to replace it with. The rest being flagged, when copy/pasted in my browser, work.

@carriewright11
Copy link
Member

This url needs to be replaced: https://github.com/jhudsl/Documentation_and_Usability/blob/main/.github/workflows/url-checker.yml. But I'm not sure what to replace it with. The rest being flagged, when copy/pasted in my browser, work.

we can push a synch from the template to here... but this is an old repo, one of the first... so @cansavvy maybe you should take a deeper look

@carriewright11
Copy link
Member

This looks good though besides the change in the index file for the link to the slides. Thank you very much for doing this. Could you also add yourself to the about page for these efforts... maybe as "Content Publishing Reviewers"? What do you think @cansavvy ?

@cansavvy
Copy link
Contributor

This looks good though besides the change in the index file for the link to the slides. Thank you very much for doing this. Could you also add yourself to the about page for these efforts... maybe as "Content Publishing Reviewers"? What do you think @cansavvy ?

Yeah I think that's the right spot for this effort. @kweav

@kweav
Copy link
Contributor Author

kweav commented May 24, 2024

This looks good though besides the change in the index file for the link to the slides. Thank you very much for doing this. Could you also add yourself to the about page for these efforts... maybe as "Content Publishing Reviewers"? What do you think @cansavvy ?

As of commit d38393a, Slides Link is in the index.Rmd file now, and added myself to About.Rmd as part of Content Publishing Reviewers -- thanks you both!

@carriewright11
Copy link
Member

LGTM! the urls seem to be an artifact of maybe the newest version being still picky about parentheses etc.

@kweav
Copy link
Contributor Author

kweav commented Sep 17, 2024

This url needs to be replaced: https://github.com/jhudsl/Documentation_and_Usability/blob/main/.github/workflows/url-checker.yml. But I'm not sure what to replace it with. The rest being flagged, when copy/pasted in my browser, work.

@cansavvy Is this link from the OTTR Template a good link to switch out for this broken URL? https://github.com/jhudsl/OTTR_Template/blob/main/.github/workflows/check-url.yml

@cansavvy
Copy link
Contributor

Replace the URL checker yml link with a current one
@kweav
Copy link
Contributor Author

kweav commented Sep 17, 2024

Good to merge now? @cansavvy and @carriewright11 ?

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kweav !!! Super necessary and long overdue.

@kweav kweav merged commit 3c8c176 into main Sep 17, 2024
7 of 8 checks passed
@kweav kweav deleted the checkLinks branch September 17, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants