Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talk about forks #48

Merged
merged 4 commits into from
Jun 26, 2024
Merged

talk about forks #48

merged 4 commits into from
Jun 26, 2024

Conversation

kweav
Copy link
Contributor

@kweav kweav commented Jun 4, 2024

Added info about forks for the getting started information

@kweav kweav requested a review from cansavvy June 4, 2024 22:34
Copy link
Contributor

github-actions bot commented Jun 4, 2024

No broken url errors! 🎉
Comment updated at 2024-06-26-19:16:25 with changes from 3ddf2fb

Copy link
Contributor

github-actions bot commented Jun 4, 2024

No spelling errors! 🎉
Comment updated at 2024-06-26-19:16:19 with changes from 3ddf2fb

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Re-rendered previews from the latest commit: See preview of website here

Updated at 2024-06-26 with changes from 3ddf2fb

Copy link
Contributor

@cansavvy cansavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment before merging. Can we move the comment about the form and how you don't have to fork the repo if you don't want to first?

But otherwise this is ready to go! Thanks so much for filing all these PRs everywhere. SUPER helpful!


Some alternative information on these steps are available [here from GitHub](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork) or from [James Priest's Gist on the Fork and PR Workflow](https://gist.github.com/james-priest/74188772ef2a6f8d7132d0b9dc065f9c) (note: you don't need to clone the forked repo locally, instead making edits online and committing to a new branch).

If you'd rather not create a fork and open a PR, we can make edits to the `sync.yml` file for you if you open an issue in the relevant repo (links in table below) providing us the information about your repo (organization or username as well as the new repo name) or submit a response in our [OTTR Feedback Google Form](https://forms.gle/jGQnd5oemHWyuUq28) providing the information for your new repo in the "Do you have any overall suggestions for OTTR?" question.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move this earlier so people know they don't have to make a fork if they don't want to. I'd hate for them to follow all the steps and then get to this point and realize they didn't have to.

@@ -132,14 +132,43 @@ When updates are made to files that aren't specific to the course content but in
- [File for the main course OTTR_Template updates](https://github.com/jhudsl/OTTR_Template/blob/main/.github/sync.yml)
- [File for the OTTR_Quizzes updates](https://github.com/jhudsl/OTTR_Quizzes/blob/main/.github/sync.yml)

#### Making edits to these files if you're not part of the jhudsl GitHub organization

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can move from below to the top here about the non-forking option?

@kweav kweav merged commit 86b8745 into main Jun 26, 2024
6 checks passed
@kweav kweav deleted the forkInfo branch June 26, 2024 19:22
@kweav kweav restored the forkInfo branch June 26, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants