Improved test coverage for Selector exceptions

jhy · Dec 14, 2024 · e0019eb · e0019eb
1 parent 34fb153
commit e0019eb
Showing 1 changed file with 29 additions and 8 deletions.
diff --git a/src/test/java/org/jsoup/select/QueryParserTest.java b/src/test/java/org/jsoup/select/QueryParserTest.java
@@ -5,6 +5,7 @@
 import org.junit.jupiter.api.Test;
 
 import static org.jsoup.select.EvaluatorDebug.sexpr;
+import static org.jsoup.select.Selector.SelectorParseException;
 import static org.junit.jupiter.api.Assertions.*;
 
 /**
@@ -103,21 +104,41 @@ public class QueryParserTest {
          */
     }
 
-    @Test public void exceptionOnUncloseAttribute() {
-        assertThrows(Selector.SelectorParseException.class, () -> QueryParser.parse("section > a[href=\"]"));
+
+    @Test
+    public void exceptionOnUncloseAttribute() {
+        Selector.SelectorParseException exception =
+            assertThrows(Selector.SelectorParseException.class, () -> QueryParser.parse("section > a[href=\"]"));
+        assertEquals(
+            "Did not find balanced marker at 'href='",
+            exception.getMessage());
     }
 
-    @Test public void testParsesSingleQuoteInContains() {
-        assertThrows(Selector.SelectorParseException.class, () -> QueryParser.parse("p:contains(One \" One)"));
+    @Test
+    public void testParsesSingleQuoteInContains() {
+        Selector.SelectorParseException exception =
+            assertThrows(Selector.SelectorParseException.class, () -> QueryParser.parse("p:contains(One \" One)"));
+        assertEquals("Did not find balanced marker at 'One '",
+            exception.getMessage());
     }
 
+    @Test
+    public void exceptOnEmptySelector() {
+        SelectorParseException exception = assertThrows(SelectorParseException.class, () -> QueryParser.parse(""));
+        assertEquals("String must not be empty", exception.getMessage());
+    }
 
-    @Test public void exceptOnEmptySelector() {
-        assertThrows(Selector.SelectorParseException.class, () -> QueryParser.parse(""));
+    @Test
+    public void exceptOnNullSelector() {
+        SelectorParseException exception = assertThrows(SelectorParseException.class, () -> QueryParser.parse(null));
+        assertEquals("String must not be empty", exception.getMessage());
     }
 
-    @Test public void exceptOnNullSelector() {
-        assertThrows(Selector.SelectorParseException.class, () -> QueryParser.parse(null));
+    @Test
+    public void exceptOnUnhandledEvaluator() {
+        SelectorParseException exception =
+            assertThrows(SelectorParseException.class, () -> QueryParser.parse("div / foo"));
+        assertEquals("Could not parse query '/': unexpected token at '/'", exception.getMessage());
     }
 
     @Test public void okOnSpacesForeAndAft() {